Currently (version 0,1) the included technology features:
- RESTful Spring MVC controllers with annotations
- A service layer with annotated Spring transactions
- Spring JDO DAOs
- Unit tests galore
- An advanced ant script
- Eclipse ready
You can now:
- See it in action at: http://swagswap.appspot.com
- Read the 10 minute installation guide and overview (including links to code!)
- Check out the source code and run it yourself.
I'll report on some appengine difficulties I've had in my next post.
Looked over the code briefly, some quick comments :
ReplyDelete1. Name, tags etc do not seem to be html escaped in the display table.
2. There's some sillyness in the javascript.
if (agree)
return true ;
else
return false ;
}
could obviously better be writen as
return agree;
3. getDefaultImage uses a very inefficient way to read a file. It reads the image byte by byte instead of using a buffer.
org.springframework.util.FileCopyUtils.copy would probably be a better choise to use. It also does the buffering for you
4. using a get for a destructive action such as delete is unwise. When google spiders your site you might end up loosing al of your swag